chore(session): decompose SessionController into focused delegates#969
Merged
Conversation
github-actions
Bot
added
type: chore
bmc08gt
force-pushed
the
chore/inject-dispatchers
branch
from
ae1eb56 to
68cbee6
Compare
bmc08gt
force-pushed
the
chore/delegate-session-controller
branch
from
98c446c to
65b6cda
Compare
bmc08gt
force-pushed
the
chore/delegate-session-controller
branch
2 times, most recently
from
a4fab36 to
9644cc7
Compare
Extract RealSessionController domain logic into 5 delegates (BillPresentationDelegate, CodeScanDelegate, CashLinkDelegate, DepositDelegate, GiftCardSharingDelegate) with a shared SessionStateHolder. The controller becomes a thin shell that wires delegates and merges their event flows. Adds sub-interfaces (BillOperations, CodeScanOperations, CashLinkOperations, DepositOperations) for narrower API surfaces. DepositDelegate owns deposit option presentation, USDC sweep lifecycle, and the depositFirstUx feature flag — extracted from CashLinkDelegate and the shell. CashLinkDelegate is now stateless with no coroutine scope. Cross-delegate events use Channel(UNLIMITED) for guaranteed delivery (replacing SharedFlow). Includes 58 passing tests, KDoc on all source files, and updated architecture docs. Signed-off-by: Brandon McAnsh <[email protected]>
bmc08gt
force-pushed
the
chore/delegate-session-controller
branch
from
9644cc7 to
76b834c
Compare
- build.gradle.kts: keep both testFixtures deps (coroutines + ui:resources) - SessionControllerGiftCardErrorTest: keep PR's delegate params, drop purchaseMethodController (not in RealSessionController), fix TestDispatcherProvider field name - UsdcDepositSweepTest: take code/cash's TestDispatchers approach
…atible - GenerateCurveTables: replace `project.hasProperty()` in onlyIf with a serializable Property wired via providers.gradleProperty() - GenerateEmojiList: extract inline doLast task into a proper abstract task class in buildSrc to avoid capturing script object references - Add kotlinx-serialization-json to buildSrc deps for emoji JSON parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract RealSessionController domain logic into 5 delegates
(BillPresentationDelegate, CodeScanDelegate, CashLinkDelegate,
DepositDelegate, GiftCardSharingDelegate) with a shared
SessionStateHolder. The controller becomes a thin shell that wires
delegates and merges their event flows. Adds sub-interfaces
(BillOperations, CodeScanOperations, CashLinkOperations,
DepositOperations) for narrower API surfaces.
DepositDelegate owns deposit option presentation, USDC sweep
lifecycle, and the depositFirstUx feature flag — extracted from
CashLinkDelegate and the shell. CashLinkDelegate is now stateless
with no coroutine scope.
Cross-delegate events use Channel(UNLIMITED) for guaranteed
delivery (replacing SharedFlow). Includes 58 passing tests, KDoc
on all source files, and updated architecture docs.